Re: [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_facility level to printk().

[Ralf Thielow]

Of course, the whole staging directory with "make clean
M=drivers/staging && make M=drivers/staging".
You're right. The "printk" function accept these but it's wrong.

Thanks

2011/3/26 Joe Perches <joe@xxxxxxxxxxx>:
> On Sat, 2011-03-26 at 17:16 +0100, Ralf Thielow wrote:
>> Includes missing KERN_ facility level to printk().
> []
>> diff --git a/drivers/staging/keucr/smscsi.c b/drivers/staging/keucr/smscsi.c
> []
>> @@ -97,7 +97,7 @@ int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb)
>> Â Â Â WORD bl_len;
>> Â Â Â BYTE buf[8];
>>
>> - Â Â printk("SM_SCSI_Read_Capacity\n");
>> + Â Â printk(KERN_DEBUG, "SM_SCSI_Read_Capacity\n");
>
> There should not be a comma between KERN_<level> and format.
>
> Compile tested?
>
>> + Â Â printk(KERN_DEBUG, "bl_len = %x\n", bl_len);
>> + Â Â printk(KERN_DEBUG, "bl_num = %x\n", bl_num);
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/