Re: [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_facility level to printk().

[Ralf Thielow]

Ooops, i thougth i can trust "make M=***".

Thanks!

2011/3/26 Joe Perches <joe@xxxxxxxxxxx>:
> On Sat, 2011-03-26 at 20:11 +0100, Ralf Thielow wrote:
>> Of course, the whole staging directory with "make clean
>> M=drivers/staging && make M=drivers/staging".
>> You're right. The "printk" function accept these but it's wrong.
>
> Then you didn't really compile test it.
> I suggest you check your compilation commands.
>
> For instance:
>
> diff --git a/drivers/staging/keucr/smscsi.c b/drivers/staging/keucr/smscsi.c
> index 6211686..dd3cf95 100644
> --- a/drivers/staging/keucr/smscsi.c
> +++ b/drivers/staging/keucr/smscsi.c
> @@ -98,7 +98,7 @@ int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb)
> Â Â Â ÂWORD Â Âbl_len;
> Â Â Â ÂBYTE Â Âbuf[8];
>
> - Â Â Â printk("SM_SCSI_Read_Capacity\n");
> + Â Â Â printk(KERN_DEBUG, "SM_SCSI_Read_Capacity\n");
>
> Â Â Â Âbl_len = 0x200;
> Â Â Â Âbl_num = Ssfdc.MaxLogBlocks * Ssfdc.MaxSectors * Ssfdc.MaxZones - 1;
>
> $ make drivers/staging/keucr/smscsi.o
> ÂCHK Â Â include/linux/version.h
> ÂCHK Â Â include/generated/utsrelease.h
> ÂCALL Â Âscripts/checksyscalls.sh
> ÂCC Â Â Âdrivers/staging/keucr/smscsi.o
> drivers/staging/keucr/smscsi.c: In function âSM_SCSI_Read_Capacityâ:
> drivers/staging/keucr/smscsi.c:101:2: warning: too many arguments for format
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/