Re: [GIT PULL] block drivers for 2.6.39-rc

[Jens Axboe]

On 2011-03-28 07:08, Stephen Rothwell wrote:
> Hi Linus, Ingo,
> 
> On Sun, 27 Mar 2011 21:37:50 -0700 Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>>
>> On Sun, Mar 27, 2011 at 9:23 PM, Ingo Molnar <mingo@xxxxxxx> wrote:
>>>
>>> This driver does not build at all:
>>>
>>>  drivers/block/drbd/drbd_bitmap.c:1187:5: error: implicit declaration of function ‘generic_find_next_zero_le_bit’ [-Werror=implicit-function-declaration]
>>>  drivers/block/drbd/drbd_bitmap.c:1190:5: error: implicit declaration of function ‘generic_find_next_le_bit’ [-Werror=implicit-function-declaration]
>>>  drivers/block/drbd/drbd_bitmap.c:1290:4: error: implicit declaration of function ‘generic___test_and_set_le_bit’ [-Werror=implicit-function-declaration]
>>>  drivers/block/drbd/drbd_bitmap.c:1292:4: error: implicit declaration of function ‘generic___test_and_clear_le_bit’ [-Werror=implicit-function-declaration]
>>>  drivers/block/drbd/drbd_bitmap.c:1441:3: error: implicit declaration of function ‘generic_test_le_bit’ [-Werror=implicit-function-declaration]
>>>
>>> Has this been build-tested? These APIs do not exist upstream.
>>
>> Actually, I think that's just a merge error - those horrible nasty
>> crazy names did use to exist.
>>
>> Does this fix it? (Untested!)
> 
> You also need to remove the include of asm-generic/bitops/le.h from that
> file now (the easiest way is to revert commit f0ff1357ce39 ("drbd: need
> include for bitops functions declarations").
> 
> Jens was informed about these problems when they appeared in linux-next.

Yes, and I merged your patch to fixup the build (on PPC, as I recall).

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/