Re: [PATCH v5] fat: Batched discard support for fat

[OGAWA Hirofumi]

Kyungmin Park <kmpark@xxxxxxxxxxxxx> writes:

>> Yes. It's what I'm saying. If user wants to trim 0-2 then user will
>> specify 0-2, but this trims only 2. It's not right.
>
> There's similar code at ext4. it adjusts the start and len value if
> given start is less than first_data_blk.
>
>        if (start < first_data_blk) {
>                 len -= first_data_blk - start;
>                 start = first_data_blk;
>         }

Oh, strange design. On this design, user have to know which block is
actually start block per FSes (Yeah, you can still use this without
start block knowledge. But it's bogus). I think it should fix ext4. No?

Thanks.
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/