Re: [PATCH] uio: fix allocating minor id for uio device

From: Wolfram Sang
Date: Tue Mar 29 2011 - 04:41:09 EST



> > - idev->minor = id & MAX_ID_MASK;
> > + if (id < UIO_MAX_DEVICES)
> > + idev->minor = id;
> > + else {

As it needs respinning anyway: If the else-block has braces, it is
recommended for the if-block, too

Regards,

Wolfram

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |

Attachment: signature.asc
Description: Digital signature