Re: [PATCH 1/6] TTY: unify tty_init_dev fail path handling
From: Jiri Slaby
Date: Tue Mar 29 2011 - 08:17:55 EST
On 03/23/2011 09:53 PM, Julian Anastasov wrote:
>
> Hello,
>
> On Wed, 23 Mar 2011, Jiri Slaby wrote:
>
>> Change it so that we call the deinit functions at one place at the end
>> of the function (by gotos). And while at it use some sane label names.
>>
>> This is a preparation for the deinitialization of tty in the next
>> patch.
>>
>> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
>> Cc: Greg Kroah-Hartman <gregkh@xxxxxxx>
>> Cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
>> Cc: Julian Anastasov <ja@xxxxxx>
>> ---
>>
>> This is not tested yet, I'm building a kernel to test it a bit, but it
>> will take some time. If you could too to check if your problem
>> dissapears, it would be great.
>
> Thanks! Patches 1-5 work for me, I backported them
> to 2.6.33.8 for the test.
Thanks for testing. I see no regressions either.
Greg, will you take it?
regards,
--
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/