Re: [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig

[OGAWA Hirofumi]

Randy Dunlap <randy.dunlap@xxxxxxxxxx> writes:

>> config PCI_LABEL
>> 	bool
>>         select NLS
>>         depends on (DMI || ACPI)
>
> What sets/enables it then?
> or did you mean:
> 	def_bool y
> and in that case, should it be a user-visible & user-changeable kconfig option?

Whoops, last line was missed by copy&paste. It meant

config PCI_LABEL
	bool
	select NLS
	depends on (DMI || ACPI)
        default y

And no, it shouldn't be user-changeable (it would be better to
invisible in .config. At make *config, already invisible.). Because
PCI_LABEL is not user config and not used in Makefile.

And yeah, if you like def_bool

config PCI_LABEL
	def_bool y if (DMI || ACPI)
	select NLS

I guess it would work (it should be just syntax sugar and equivalent).

Thanks.
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/