Re: [PATCH]mmap: add alignment for some variables

[Andrew Morton]

On Tue, 29 Mar 2011 08:54:14 +0800
Shaohua Li <shaohua.li@xxxxxxxxx> wrote:

> -struct percpu_counter vm_committed_as;
> +struct percpu_counter vm_committed_as ____cacheline_internodealigned_in_smp;

Why ____cacheline_internodealigned_in_smp?  That's pretty aggressive.

afacit the main benefit from this will occur if the read-only
vm_committed_as.counters lands in the same cacheline as some
write-frequently storage.

But that's a complete mad guess and I'd prefer not to have to guess.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/