Re: [PATCH 09/23] hdaps: Convert printks to pr_<level>

[Joe Perches]

On Tue, 2011-03-29 at 22:54 -0300, Lucas De Marchi wrote:
> > diff --git a/drivers/platform/x86/hdaps.c b/drivers/platform/x86/hdaps.c
> > @@ -238,7 +240,7 @@ static int hdaps_device_init(void)
> >                     __check_latch(0x1611, 0x01))
> >                goto out;
> >
> > -       printk(KERN_DEBUG "hdaps: initial latch check good (0x%02x).\n",
> > +       printk(KERN_DEBUG "hdaps: initial latch check good (0x%02x)\n",
> 
> Shouldn't this be pr_debug() or pr_devel() ?

Hi Lucas.

Using pr_debug changes behavior unless
CONFIG_DYNAMIC_DEBUG or #define DEBUG is used.

I prefer not to change those unless there's
agreement.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/