Re: [PATCH] pch_gpio: Fix output value ofpch_gpio_direction_output()

[Peter Tyser]

On Wed, 2011-03-30 at 21:16 +0900, Tomoya MORINAGA wrote:
> The pch_gpio_direction_output() function was missing a write to set the
> desired output value.  The function would properly set the GPIO
> direction, but not the output value.  The value would have to manually
> be set with a follow up call to pch_gpio_set().
> 
> Add the missing write so that pch_gpio_direction_output() sets both the
> GPIO direction and value.
> 
> Reported-by: Peter Tyser <ptyser@xxxxxxxxxxx>
> Signed-off-by: Tomoya MORINAGA <tomoya-linux@xxxxxxxxxxxxxxx>

Hi Tomoya,
I posted this same patch last week:
https://patchwork.kernel.org/patch/662621/

It looks like this driver and the ml_ioh_gpio driver are nearly
identical, hence the identical fixes.  If you have some spare cycles
it'd be nice to combine them.

Best,
Peter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/