Re: [PATCH] kmemleak: build kmemleak-test.c as a module-only

From: Randy Dunlap
Date: Wed Mar 30 2011 - 11:24:26 EST


On Wed, 30 Mar 2011 18:02:02 +0300 Daniel Baluta wrote:

> On Fri, Mar 25, 2011 at 4:05 PM, Daniel Baluta <dbaluta@xxxxxxxxxxx> wrote:
> > On Wed, Mar 23, 2011 at 1:24 PM, Catalin Marinas
> > <catalin.marinas@xxxxxxx> wrote:
> >> On Wed, 2011-03-16 at 18:16 +0000, Daniel Baluta wrote:
> >>> mm/kmemleak-test.c is used to provide an example of how kmemleak
> >>> tool works.
> >>>
> >>> Memory is leaked at module unload-time, so building the test
> >>> in kernel (Y) makes the leaks impossible and the test useless.
> >>>
> >>> Qualify DEBUG_KMEMLEAK_TEST config symbol with "depends on m",
> >>> to restrict module-only building.
> >>>
> >>> Signed-off-by: Daniel Baluta <dbaluta@xxxxxxxxxxx>
> >>
> >> Sorry for the delay.
> >>
> >> Acked-by: Catalin Marinas <catalin.marinas@xxxxxxx>
> >
> > Who should pick this up?
> >
> > $ scripts/get_maintainer.pl lib/this.patch says:
> > Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> (commit_signer:8/56=14%)
> > "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx> (commit_signer:7/56=12%)
> > Ingo Molnar <mingo@xxxxxxx> (commit_signer:5/56=9%)
> > Frederic Weisbecker <fweisbec@xxxxxxxxx> (commit_signer:5/56=9%)
> > Randy Dunlap <rdunlap@xxxxxxxxxxxx> (commit_signer:3/56=5%)
>
> Catalin, Randy since lib/Kconfig.debug has no official maintainer
> I think this should go up through your trees.

I hadn't seen it until now, but I can merge it.

thanks.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/