Re: Help with dma on PCI driver

[Jonathan Corbet]

On Wed, 30 Mar 2011 13:11:40 -0300
Luis Rossi <luisf.rossi@xxxxxxxxx> wrote:

> should i stop the inti function on the device register,
> and make all the rest inside probe? It makes a lot of sense as the
> rest should be called just if the device is connected...

Yes, you should.  Also, please look at your cdev_add() call and bear in
mind that your device can be accessed immediately after that call.  You
should not call cdev_add() until the device is completely initialized and
ready to go.

Some thought given to locking would also not be misplaced.

Thanks,

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/