Re: block: eliminate ELEVATOR_INSERT_REQUEUE

From: Jens Axboe
Date: Wed Mar 30 2011 - 14:12:28 EST


On 2011-03-30 19:56, Jeff Moyer wrote:
> Jens Axboe <axboe@xxxxxxxxx> writes:
>
>> On 2011-03-30 17:30, Tejun Heo wrote:
>>> On Wed, Mar 30, 2011 at 11:22:48AM -0400, Vivek Goyal wrote:
>>>> So wee need this as stable fix because FLUSH request can get ahead of
>>>> REQUEUED requests and it can break some drivers?
>>>
>>> Yes, I think so. All we need is just replacing elv_insert() calls in
>>> blk-flush.c with list_add_tail(). Something like the following. I'll
>>> test it and send a proper patch later. Thanks.
>>
>> I'd suggest I just mark the queued patch for stable.
>
> Could you document the nuance in that patch, please?

Yeah I will. I rebase for-linus, it's not a "stable" branch as such.
Today I mainly collected some items as not to drop them, I'll expand on
the explanations in there.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/