Re: [PATCH 2/2] printk: Allocate kernel log buffer earlier v2

From: Ingo Molnar
Date: Thu Mar 31 2011 - 02:48:38 EST



* Mike Travis <travis@xxxxxxx> wrote:

> Subject: printk: Allocate kernel log buffer earlier v2
>
> On larger systems, because of the numerous ACPI, Bootmem and EFI
> messages, the static log buffer overflows before the larger one
> specified by the log_buf_len param is allocated. Minimize the
> overflow by allocating the new log buffer as soon as possible.
>
> The allocation method is passed in as an argument to make
> backporting to "pre-memblock" kernels easier.

Hm, all that allocation pointer magic looks a tad too complex and non-obvious.

Why not just make it as simple and obvious as possible for the current kernel -
and we can still mark it -stable and you backport it to the non-memblock
kernel? That keeps compatibility complexity out of upstream ...

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/