Re: [PATCH] acer-wmi: does not set persistence state byrfkill_init_sw_state
From: Florian Mickler
Date: Thu Mar 31 2011 - 04:31:42 EST
On Wed, 30 Mar 2011 22:17:57 +0200
Florian Mickler <florian@xxxxxxxxxxx> wrote:
> From: Lee, Chun-Yi <joeyli.kernel@xxxxxxxxx>
>
> Acer BIOS keeps devices state when system reboot, but reset to default
> device states (Wlan on, Bluetooth off, wwan on) if system cold boot.
> That means BIOS's initial state is not always real persistence.
>
> So, removed rfkill_init_sw_state because it sets initial state to
> persistence then replicate to other new killswitch when rfkill-input
> enabled.
> After removed it, acer-wmi set initial soft-block state after rfkill
> register, and doesn't allow set_block until rfkill initial finished.
>
> Reference: bko#31002
> https://bugzilla.kernel.org/show_bug.cgi?id=31002
>
> Cc: Carlos Corbacho <carlos@xxxxxxxxxxxxxxxxxxx>
> Cc: Matthew Garrett <mjg@xxxxxxxxxx>
> Cc: Dmitry Torokhov <dtor@xxxxxxx>
> Cc: Corentin Chary <corentincj@xxxxxxxxxx>
> Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> Signed-off-by: Lee, Chun-Yi <jlee@xxxxxxxxxx>
> Signed-off-by: Matthew Garrett <mjg@xxxxxxxxxx>
> Tested-by: OldÃÂich JedliÃÂka <oldium.pro@xxxxxxxxx>
> Signed-off-by: Florian Mickler <florian@xxxxxxxxxxx>
> ---
>
> This fixes a regression, but no stable annotation was given...
>
> Oversight? Matthew/Chun-Yi please take a look.
>
I forgot: This is upstream
commit 8215af019040ce9182728afee9642d8fdeb17f59 .
As for the Tested-by:, I think that's borked in git. At least I can't
get it out of git correctly. It should be:
Tested-by: OldÅich JedliÄka <oldium.pro@xxxxxxxxx>
Thanks,
Flo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/