Re: [PATCH][POKE] Skip looking for ioapic overrides when ioapicsare not present

From: Florian Mickler
Date: Thu Mar 31 2011 - 07:00:17 EST


On Thu, 31 Mar 2011 10:43:42 +0200
Ingo Molnar <mingo@xxxxxxx> wrote:

>
> * Florian Mickler <florian@xxxxxxxxxxx> wrote:
>
> > From: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
> >
> > [I submit this as the corresponding bug report is still not closed, the patch
> > not merged, distributions applying this patch, it is tested to work and I found
> > nowhere any resoning as to why this should be out of tree. I just guessed on
> > the stable tag and number. -Florian]
>
> The patch does not build when CONFIG_ACPI is disabled:
>
> arch/x86/kernel/apic/io_apic.c: In function âacpi_get_override_irqâ:
> arch/x86/kernel/apic/io_apic.c:3792:6: error: âacpi_irq_modelâ undeclared (first use in this function)
> arch/x86/kernel/apic/io_apic.c:3792:24: error: âACPI_IRQ_MODEL_IOAPICâ undeclared (first use in this function)
>
> When you or Eric resubmits the fixed patch please use the improved changelog
> below.
>
> Thanks,
>
> Ingo

Thank you. Will do if it turns out this is still necessary.
Paul Bolle mentioned in another messgage that there is a commit in
2.6.38 to the same effect:

commit 678301ecadec24ff77ab310eebf8a32ccddb1850
("x86, ioapic: Don't warn about non-existing IOAPICs if we have none")

Regards,
Flo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/