Re: [PATCH 4/4] Staging: iio: accel : sca3000_ring: Fixing codestyling issues

[Belisko Marek]

On Wed, Apr 6, 2011 at 9:14 PM,  <nijs.michael@xxxxxxxxx> wrote:
> From: Michael Nijs <nijs.michael@xxxxxxxxx>
>
> Fixed code styling issue.
>
> Signed-off-by: Michael Nijs <nijs.michael@xxxxxxxxx>
> ---
> Âdrivers/staging/iio/accel/sca3000_ring.c | Â Â2 +-
> Â1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/iio/accel/sca3000_ring.c b/drivers/staging/iio/accel/sca3000_ring.c
> index fd1c844..c872fdd 100644
> --- a/drivers/staging/iio/accel/sca3000_ring.c
> +++ b/drivers/staging/iio/accel/sca3000_ring.c
> @@ -91,7 +91,7 @@ static int sca3000_rip_hw_rb(struct iio_ring_buffer *r,
>
> Â Â Â Â/* Convert byte order and shift to default resolution */
> Â Â Â Âif (st->bpse == 11) {
> - Â Â Â Â Â Â Â samples = (s16 *)(*data+1);
> + Â Â Â Â Â Â Â samples = (s16*)(*data+1);
Strange. My output(latest 2.6.39-rc2):
./scripts/checkpatch.pl -f drivers/staging/iio/accel/sca3000_ring.c
ERROR: "(foo*)" should be "(foo *)"
#94: FILE: staging/iio/accel/sca3000_ring.c:94:
+		samples = (s16*)(*data+1);

So for me it seems it was correct and you post patch with change where
checkpatch will bark. Or am I missing something?
> Â Â Â Â Â Â Â Âfor (i = 0; i < (num_read/2); i++) {
> Â Â Â Â Â Â Â Â Â Â Â Âsamples[i] = be16_to_cpup(
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â(__be16 *)&(samples[i]));
> --
> 1.7.2.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
> Please read the FAQ at Âhttp://www.tux.org/lkml/
>

thanks,

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
icq: 290551086
web: http://open-nandra.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/