Re: [PATCHv2 6/7] basic_mmio_gpio: support different input/outputregisters

From: Jamie Iles
Date: Fri Apr 08 2011 - 10:40:59 EST


On Fri, Apr 08, 2011 at 06:36:41PM +0400, Anton Vorontsov wrote:
> On Fri, Apr 08, 2011 at 03:16:50PM +0100, Jamie Iles wrote:
> [...]
> > + res_in = platform_get_resource_byname(pdev, IORESOURCE_MEM, "in");
> > + if (res_in) {
> > + bgc->reg_in = bgpio_request_and_map(&pdev->dev, res_in);
> > + if (!bgc->reg_in)
> > + return -ENOMEM;
> > + bgc->gc.get = bgpio_get_in;
> > + } else {
> > + bgc->gc.get = bgpio_get_dat;
> > + }
> > +
> > + return 0;
> > +}
> > +
> > return 0;
> > }
>
> Hm.. will this compile?

No, I accidentally squashed patches 6 and 7 together then obviously
didn't split them properly. I'll fix this (and the spacing around the
locking and repost).

Sorry!

Jamie
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/