Re: [PATCH] Allow O_SYNC to be set by fcntl(F_SETFL)

From: Christoph Hellwig
Date: Fri Apr 08 2011 - 11:15:00 EST

I actually prototypes this patch independetly a while ago, and in
addition to the data writeout when removing O_SYNC there are the
following caveats:

- O_SYNC is not actually one flag, but two: O_DSYNC and __O_SYNC.
setfl() needs to make sure __O_SYNC cannot be in f_flags without
O_DSYNC also beeing present.
- we need to audit all filesystems that they don't do stupid things
when the O_SYNC flags appear or disappear during a write, that
is make sure it is checked in just one place. The generic write
code is fine in that respect, but I didn't go through all filesystems
to verify it yet.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at