Re: [RFC][PATCH] bcmai: introduce AI driver

[RafaÅ MiÅecki]

2011/4/8 Arend van Spriel <arend@xxxxxxxxxxxx>:
> On Fri, 08 Apr 2011 18:56:13 +0200, RafaÅ MiÅecki <zajec5@xxxxxxxxx> wrote:
>
>> 2011/4/6 Arend van Spriel <arend@xxxxxxxxxxxx>:
>>>
>>> 3. Device identification
>>>
>>> The cores are identified by manufacturer, core id and revision in your
>>> patch. I would not use the revision because 4 out of 5 times a revision
>>> change does indicate a hardware change but no change in programming
>>> interface. The enumeration data does contain a more selective field
>>> indicating the core class (4 bits following the core identifier). I
>>> suggest
>>> to replace the revision field by this class field.
>>
>> Could you say something more about *class*, please? For my BCM43224 it
>> seems to be 0x0. WIll check BCM4313 in a moment.
>>
>
> In principal the manufacturer id is unique (defined/assigned by JEDEC
> www.jedec.org) and the chip id and chip class are defined by the
> manufacturer. So I can only indicate what classes Broadcom uses in
> combination with the manufacturer id BRCM, ARM and MIPS.
>
> /* Component Classes */
> #define CC_SIM Â Â Â Â Â Â Â Â Â0
> #define CC_EROM Â Â Â Â Â Â Â Â 1
> #define CC_CORESIGHT Â Â Â Â Â Â9
> #define CC_VERIF Â Â Â Â Â Â Â Â0xb
> #define CC_OPTIMO Â Â Â Â Â Â Â 0xd
> #define CC_GEN Â Â Â Â Â Â Â Â Â0xe
> #define CC_PRIMECELL Â Â Â Â Â Â0xf
>
> Looking at this it seems strange that you see a class value of 0x0. It may
> be rarely used or for non-production chips only (for simulation, chip
> bringup) which may require additional (debug) functions. So question is
> whether you will need it, but it is specified by ARM and it is up to
> manufacturers to use it. So I it is better to be safe than sorry and have
> this in the device id.

OK, thanks. I'm compiling kernel with patch V2 right now. Of course
class included.

-- 
RafaÅ
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/