Re: [PATCH] perf: Don't schedule tracepoints when exclude_kernelis set
From: Frederic Weisbecker
Date: Sat Apr 09 2011 - 09:28:22 EST
On Sat, Apr 09, 2011 at 03:14:44PM +0200, Peter Zijlstra wrote:
> On Fri, 2011-04-08 at 22:57 +0200, Frederic Weisbecker wrote:
> > Instead of checking attr.exclude_kernel anytime a tracepoint
> > event triggers, simply don't schedule the tracepoint it that
> > attribute is set. This makes one test less in the tracing
> > path.
> Meh, I'd much rather someone spend some time on finishing the below,
> which is a much bigger improvement for trace-events.
I secretely added that to my pile already :)
That's indeed something we really want.
The above is just a little thing I noticed yesterday and I wanted
to fix. Nothing more.
About that tracepoint collection, I'm not sure I like the idr though.
That thing seems to be O(log(n)), I which we can rather approach O(1)
when possible, using a hlist perhaps.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/