Re: [PATCH] iwlegacy: make iwl3945 and iwl4965 select IWLWIFI_LEGACY

From: John W. Linville
Date: Mon Apr 11 2011 - 15:00:29 EST


On Mon, Apr 11, 2011 at 11:39:22AM -0700, wwguy wrote:
> On Mon, 2011-04-11 at 10:06 -0700, John W. Linville wrote:
> > Otherwise, IWLWIFI_LEGACY has to be selected independently before the
> > drivers are made available.
> >
> > Reported-by: Dave Airlie <airlied@xxxxxxxxx>
> > Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx>
> > Cc: Stanislaw Gruszka <sgruszka@xxxxxxxxxx>
> > Cc: Wey-Yi Guy <wey-yi.w.guy@xxxxxxxxx>
> > ---
> > drivers/net/wireless/iwlegacy/Kconfig | 9 +++++----
> > 1 files changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/net/wireless/iwlegacy/Kconfig b/drivers/net/wireless/iwlegacy/Kconfig
> > index 2a45dd4..aef65cd 100644
> > --- a/drivers/net/wireless/iwlegacy/Kconfig
> > +++ b/drivers/net/wireless/iwlegacy/Kconfig
> > @@ -1,6 +1,5 @@
> > config IWLWIFI_LEGACY
> > - tristate "Intel Wireless Wifi legacy devices"
> > - depends on PCI && MAC80211
> > + tristate
> > select FW_LOADER
> > select NEW_LEDS
> > select LEDS_CLASS
>
> Should we add some ---help--- here?, or not..

Why would you need it? This is now automatically selected by the
driver -- the user doesn't see it.

--
John W. Linville Someday the world will need a hero, and you
linville@xxxxxxxxxxxxx might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/