Re: [PATCH 05/10] block: remove per-queue plugging

From: Jens Axboe
Date: Tue Apr 12 2011 - 02:20:50 EST

On 2011-04-12 00:58, hch@xxxxxxxxxxxxx wrote:
> Looking at the patch
> (;a=commitdiff;h=761e433f3de6fb8e369af9e5c08beb86286d023f)
> I'm not sure it's an optimal design. The flush callback really
> is a per-queue thing. Why isn't it a function pointer in the request
> queue when doing the blk_run_queue call once we're done with a given
> queue before moving on to the next one?

I was thinking about this yesterday as well, the design didn't quite
feel just right. Additionally the user now must track this state too,
and whether he's plugged on that task or not.

I'll rewrite this.

Jens Axboe

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at