Re: [PATCH 3/6] signal: sigprocmask: narrow the scope of ->sigloc

From: Matt Fleming
Date: Tue Apr 12 2011 - 07:38:34 EST


On Mon, 11 Apr 2011 19:21:09 +0200
Oleg Nesterov <oleg@xxxxxxxxxx> wrote:

> No functional changes, preparation to simplify the review of the next
> change.
>
> 1. We can read current->block lockless, nobody else can ever change
> this mask.

Is it worth mentioning this in a comment? What is the reason that it's
OK? Is it because we only ever modify current->blocked and never
another task's blocked signals and that we never modify
current->blocked from within any form of interrupt context?

Some of the code in fs/{autofs4,coda} seems to do interesting things
with current->blocked, particularly the daemon stuff in autofs4.

--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/