Re: [PATCH 2/6] signal: retarget_shared_pending: considershared/unblocked signals only

From: Matt Fleming
Date: Tue Apr 12 2011 - 07:40:29 EST

On Mon, 11 Apr 2011 19:20:45 +0200
Oleg Nesterov <oleg@xxxxxxxxxx> wrote:

> exit_signals() checks signal_pending() before
> retarget_shared_pending() but this is suboptimal. We can avoid the
> while_each_thread() loop in case when there are no shared signals
> visible to us.
> Add the has_pending_signals(shared_pending, blocked) check. We don
> not use tsk->blocked directly but pass this sigset_t as an argument,
> this is needed for the next patch.
> Note: we can optimize this more. while_each_thread(t) can check
> t->blocked into account and stop after every pending signal has the
> new target.
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

Nice. Do you have plans to implement that further optimisation?

Reviewed-by: Matt Fleming <matt.fleming@xxxxxxxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at