Re: [PATCH v2] rfkill: Regulator consumer driver for rfkill

[Johannes Berg]

On Tue, 2011-04-12 at 08:15 -0700, Mark Brown wrote:
> On Tue, Apr 12, 2011 at 01:44:02PM +0200, Johannes Berg wrote:
> > On Tue, 2011-04-12 at 13:41 +0200, Johannes Berg wrote:
> 
> > > > +	if (pdata->name == NULL || pdata->type == 0) {
> > > > +		dev_err(&pdev->dev, "invalid name or type in platform data\n");
> > > > +		return -EINVAL;
> > > > +	}
> 
> > > > +	vcc = regulator_get_exclusive(&pdev->dev, "vrfkill");
> 
> > > Wasn't that supposed to use pdata->supply? Actually, there's no member
> > > "supply" in the struct?
> 
> No, if you're passing supply names through platform data something has
> gone wrong - that's a big no no.

Ok. The comment seems a little wrong still though, maybe leftover bits
from an older version?

> > Oh wait, I think I just misunderstood how this works. But if the name is
> > "vrfkill" how does that really work with multiple instances?
> 
> That's what the struct device is there for.  The names are mapped into
> physical regulators relative to the device.

Oh ok, makes sense, thanks for the clarification.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/