Re: [RFC][PATCH V3] axi: add AXI bus driver
From: RafaÅ MiÅecki
Date: Tue Apr 12 2011 - 11:25:47 EST
2011/4/12 Greg KH <greg@xxxxxxxxx>:
> On Tue, Apr 12, 2011 at 07:41:18AM +0200, RafaÅ MiÅecki wrote:
>> > You can't do that, no static struct devices please. ÂMake these dynamic
>> > and everything will be fine. ÂThe -mm tree used to have a huge warning
>> > if you ever tried to register a statically allocated struct, but that
>> > didn't really work out, but would have saved you a lot of time here,
>> > sorry.
>> > So dynamically allocate the structures and you will be fine.
>> Well, I saw that along kernel, I had no idea there is anything wrong
>> about this. It seems more ppl do not know about this:
>> struct radeon_ib Â Â Âibs[RADEON_IB_POOL_SIZE];
>> struct radeon_pm_clock_info clock_info;
>> struct radeon_pm_profile profiles[PM_PROFILE_MAX];
>> struct radeon_surface_reg surface_regs[RADEON_GEM_MAX_SURFACES];
> Are you sure these are all containing a 'struct device'?
I didn't catch from you mail that you mean "struct device" only. I
though it apply to all structs.
>> checkpatch does no catch this, so maybe just some manual? Could you
>> point me to it?
> It's a structure that has dynamic lifetime rules, you can't statically
> allocate it safely. ÂIt's that simple.
Ah, and this is a great explanation, for all the time I tough the
problem is memory issue. Now it makes sense, thanks.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/