Re: [PATCH 1/4]percpu_counter: make API return consistent value

From: Tejun Heo
Date: Tue Apr 12 2011 - 14:49:39 EST


First of all, please somehow link patches of the same series. Either
write a head message and make all the patches replies to it
(preferred) or chain reply the patches (only when the number of
patches is small).

On Tue, Apr 12, 2011 at 04:03:57PM +0800, Shaohua Li wrote:
> the percpu_counter_*_positive() API SMP and !SMP aren't consistent. From
> the API name, we should return a non-negative value for them.
> Also if count < 0, returns 0 instead of 1 for *read_positive().

Ummm, on UP, the counters cannot be positive. The _positive interface
is there to make it easier to cope with deviations introduced by
unsynchronized modifications by different CPUs. On UP, such
deviations don't happen at all so _positive interface is the same as
the counterpart without the postfix.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at