Re: [PATCH]: mce: don't print "human readable" message for correctederrors

[Prarit Bhargava]

On 04/12/2011 02:58 PM, Borislav Petkov wrote:
> On Tue, Apr 12, 2011 at 01:44:05PM -0400, Prarit Bhargava wrote:
>   
>> Don't display the "human readable" warning for correctable errors in mce.
>> There is no need for this information to be displayed.
>>
>> Signed-off-by: Prarit Bhargava <prarit@xxxxxxxxxx>
>>     
> Why not? This way you turn reporting of _ALL_ correctable MCEs
> completely off and some users would actually like to run them through
> mcelog on Intel.
>   

I may be reading the code wrong ... but in the case of the
default_decode_mce() callback there is *no* additional output displayed
for correctable MCEs -- so the message is AFAICT useless.

ie) all you see on the console log is

[Hardware Error]: Machine check events logged

^^^ this notifies the user that something happened with MCE

[Hardware Error]: No human readable MCE decoding support on this CPU type.

^^^ this is purely informational and unnecessary

[Hardware Error]: Run the message through 'mcelog --ascii' to decode.

^^^ this makes absolutely no sense.  There is no message to decode.

You won't see this in the case of the amd-edac because it has it's own
callback.

P.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/