Re: [PATCH 0/5] consolidate sdhci pltfm & OF drivers and get themself registered

From: Shawn Guo
Date: Wed Apr 13 2011 - 02:22:46 EST


Hi Wolfram,

On Thu, Mar 31, 2011 at 12:36:53PM -0400, Chris Ball wrote:
> Hi Wolfram,
>
> On Fri, Mar 25 2011, Shawn Guo wrote:
> > Here are what the patch set does.
> >
> > * Remove .probe and .remove hooks from sdhci-pltfm.c and make it be
> > a pure common helper function providers.
> > * Add .probe and .remove hooks for sdhci pltfm drivers sdhci-cns3xxx,
> > sdhci-dove, sdhci-tegra, and sdhci-esdhc-imx to make them self
> > registered with calling helper functions created above.
> > * Migrate the use of sdhci_of_host and sdhci_of_data to
> > sdhci_pltfm_host and sdhci_pltfm_data, so that OF version host and
> > data structure works can be saved, and pltfm version works for both
> > cases.
> > * Add OF common helper stuff into sdhci-pltfm.c, and make OF version
> > sdhci drivers sdhci-of-esdhc and sdhci-of-hlwd become self
> > registered as well, so that sdhci-of-core.c and sdhci-of.h can be
> > removed.
> > * Consolidate the OF and pltfm esdhc drivers into one with sharing
> > the same pair of .probe and .remove hooks. As a result,
> > sdhci-esdhc-imx.c and sdhci-of-esdhc.c go away, while
> > sdhci-esdhc.c comes in and works for both MPCxxx and i.MX.
> > * Eliminate include/linux/mmc/sdhci-pltfm.h with moving stuff into
> > drivers/mmc/host/sdhci-pltfm.h.
>
> If you get time, would appreciate getting an ACK from you on the patch
> changes (including Grant's review). Thanks very much!
>
Can you please take some time to help review? I know you are on ELC
this week :) What about next couple of weeks?

--
Regards,
Shawn

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/