Re: [PATCH 4/5] usb/gadget: don't deploy SS descriptors if SS is notenabled.

[Michal Nazarewicz]

On Wed, 13 Apr 2011 12:56:57 +0200, Sebastian Andrzej Siewior  
<bigeasy@xxxxxxxxxxxxx> wrote:

> Sergei Shtylyov wrote:
> > Hello.
>
> Hello Sergei,
>
> > Cleaned-up example:
> >  (in header)
> >     #ifndef CONFIG_NET_FUNKINESS
> >     static inline void init_funky_net (struct net_device *d) {}
> >     #endif
> >  (in the code itself)
> >     dev = alloc_etherdev (sizeof(struct funky_private));
> >     if (!dev)
> >         return -ENODEV;
> >     init_funky_net(dev);
>
> The problem here is that the code is included via
>
>    #include "composite.c
>
> so we don't really use header files. The alternative would be to use the
> gadget_is_super_speed() function but that one takes a gadget as argument.
> Preferences?

#ifdef CONFIG_USB_GADGET_SUPERSPEED
void usb_create_ss_descriptors(struct usb_function *f)
{
	/* ... */
}
#else
static inline void usb_create_ss_descriptors(struct usb_function *f) { }
#endif

Is usually preferred.

--
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michal "mina86" Nazarewicz    (o o)
ooo +-----<email/xmpp: mnazarewicz@xxxxxxxxxx>-----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/