Re: [patch v2 1/4] percpu_counter: change return value and addcomments

From: Tejun Heo
Date: Wed Apr 13 2011 - 15:06:07 EST

On Wed, Apr 13, 2011 at 03:57:16PM +0800, wrote:
> the percpu_counter_*_positive() API SMP and UP aren't consistent. Add comments
> to explain it.
> Also if count < 0, returns 0 instead of 1 for *read_positive().
> Signed-off-by: Shaohua Li <>

Patch looks technically okay to me but may I suggest...

* Revise patch description. It doesn't really match the patch

* I would much prefer having docbook comments on top of
*read_positive() functions.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at