Re: [patch v2 1/4] percpu_counter: change return value and addcomments

[Tejun Heo]

On Wed, Apr 13, 2011 at 03:57:16PM +0800, shaohua.li@xxxxxxxxx wrote:
> the percpu_counter_*_positive() API SMP and UP aren't consistent. Add comments
> to explain it.
> Also if count < 0, returns 0 instead of 1 for *read_positive().
> 
> Signed-off-by: Shaohua Li <shaohua.li@xxxxxxxxx>

Patch looks technically okay to me but may I suggest...

* Revise patch description.  It doesn't really match the patch
  content.

* I would much prefer having docbook comments on top of
  *read_positive() functions.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/