Re: Re-send (What else needs to be done to the sep driver(staging/sep))
From: Greg KH
Date: Wed Apr 13 2011 - 18:47:26 EST
On Wed, Apr 13, 2011 at 03:30:36PM -0700, Joe Perches wrote:
> On Wed, 2011-04-13 at 15:23 -0700, Greg KH wrote:
> > Ick, no, never use your own macros, just use the "real" things like is
> > done in this driver. If it's a pain to get to that pointer, then use a
> > temporary variable in the code and then use it.
> > Otherwise, no, I don't like this patch at all, sorry.
> I think you're simply incorrect here.
> There are lots of other uses like netdev_<foo>
> where <foo>_<level> takes a particular pointer type.
> This is a structure that contains a pointer to
> another structure than contains a struct device.
> You might also look at the macros the USB subsystem
> uses for message logging.
> Hey, aren't you the USB maintainer?
Yes, and over time we have been moving away from using those macros. I
don't like seeing every individual driver have its own way of handling
debug macros, that's crazy.
For larger stuff like networking, yes, they can do that, and that's
fine. They also were doing this before the dev_* macros came along,
just like USB did, so there is historical precident there.
But again, not for a new driver, don't redefine the existing macros just
because you don't like typing a few extra characters...
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/