Re: [Stable-review] [18/71] xfs: prevent leaking uninitializedstack memory in FSGEOMETRY_V1

From: Ben Hutchings
Date: Wed Apr 13 2011 - 23:50:39 EST

On Wed, 2011-04-13 at 09:09 -0700, Greg KH wrote:
> 2.6.33-longterm review patch. If anyone has any objections, please let us know.
> ------------------
> From: Dan Rosenberg <drosenberg@xxxxxxxxxxxxx>
> commit c4d0c3b097f7584772316ee4d64a09fe0e4ddfca upstream.
> The FSGEOMETRY_V1 ioctl (and its compat equivalent) calls out to
> xfs_fs_geometry() with a version number of 3. This code path does not
> fill in the logsunit member of the passed xfs_fsop_geom_t, leading to
> the leaking of four bytes of uninitialized stack data to potentially
> unprivileged callers.

Needs a subsequent fix, like the corresponding bug fix in


Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

Attachment: signature.asc
Description: This is a digitally signed message part