Re: [PATCH] net: ipv4: add IPPROTO_ICMP socket kind

[Simon Horman]

On Wed, Apr 13, 2011 at 01:29:49PM +0300, Alexey Dobriyan wrote:
> On Sat, Apr 9, 2011 at 1:15 PM, Vasiliy Kulikov <segoon@xxxxxxxxxxxx> wrote:

[snip]

> > @@ -714,8 +790,22 @@ static __net_init int ipv4_sysctl_init_net(struct net *net)
> > Â Â Â Â Â Â Â Â Â Â Â Â&net->ipv4.sysctl_icmp_ratemask;
> > Â Â Â Â Â Â Â Âtable[6].data =
> > Â Â Â Â Â Â Â Â Â Â Â Â&net->ipv4.sysctl_rt_cache_rebuild_count;
> > +#ifdef CONFIG_IP_PING
> > + Â Â Â Â Â Â Â table[7].data =
> > + Â Â Â Â Â Â Â Â Â Â Â &net->ipv4.sysctl_ping_group_range;
> > +#endif
> 
> Now I understand it's not related, but next sysctl will have
> "table[8].data = ..." line which is off-by-one if CONFIG_IP_PING=n.

Another good reason for the code to be non-optoinal
and not to have CONFIG_IP_PING.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/