Re: [stable] [PATCH V4] futex: set FLAGS_HAS_TIMEOUT during demuxfor FUTEX_WAIT

From: Darren Hart
Date: Thu Apr 14 2011 - 18:13:55 EST


On 04/14/2011 02:56 PM, Greg KH wrote:
> On Thu, Apr 14, 2011 at 02:43:01PM -0700, Darren Hart wrote:
>> The FLAGS_HAS_TIMEOUT flag was not getting set, causing the restart_block to
>> restart futex_wait() without a timeout after a signal.
>>
>> Commit b41277dc7a18ee332d in 2.6.38 introduced the regression by accidentally
>> removing the the FLAGS_HAS_TIMEOUT assignment from futex_wait() during the setup
>> of the restart block. Restore the originaly behavior.
>>
>> Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=32922
>>
>> V2: Added references to commit message.
>> V3: Set flag during restart block instead of do_futex()
>> V4: Correct stupid order of assignment mistake pointed out by Eric
>>
>> Signed-off-by: Darren Hart <dvhart@xxxxxxxxxxxxxxx>
>> Reported-by: Tim Smith <tsmith201104@xxxxxxxxx>
>> Reported-by: Torsten Hilbrich <torsten.hilbrich@xxxxxxxxxxx>
>> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
>> Cc: Ingo Molnar <mingo@xxxxxxx>
>> CC: Eric Dumazet <eric.dumazet@xxxxxxxxx>
>> CC: John Kacur <jkacur@xxxxxxxxxx>
>> ---
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree. Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.

Sigh, apologies. Fixing, will add stable to CC: in changelog. Gives me a
chance to improve the subject anyway.

Ingo, Greg, please ignore this and the previous V[123] patches.

--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/