Re: [Xen-devel] [PATCH] [PV Xen] Mouse stuck after save/restore ofguest.

From: Olaf Hering
Date: Fri Apr 15 2011 - 05:37:59 EST


On Thu, Apr 14, Konrad Rzeszutek Wilk wrote:

> On Thu, Apr 14, 2011 at 07:26:50PM +0200, Olaf Hering wrote:
> > On Thu, Apr 14, Konrad Rzeszutek Wilk wrote:
> >
> > > On Thu, Apr 14, 2011 at 05:45:07PM +0200, Igor Mammedov wrote:
> > > > Mouse stuck after restore of PV guest but buttons are
> > > > in working condition.
> > > > If driver has been configured for ABS coordinates at
> > > > start it will get XENKBD_TYPE_POS events and then
> > > > suddenly after restore it'll start getting
> > > > XENKBD_TYPE_MOTION events, that will be dropped later
> > > > and they won't get into user-space.
> > > >
> > > > Regression was introduced by hunk 5 and 6 of 5ea5254
> > > > in upstream.
> > > >
> > > > Driver on restore should ask xen for request-abs-pointer
> > > > again if it's available. So restore parts that did it
> > > > before 5ea5254.
> > >
> > > Olaf?
> >
> > This change is correct. Thanks for spotting, Igor.
>
> Dmitry,
>
> Was wondering if you are OK pushing this for 2.6.39-rc3 or whether you are OK
> with me doing. It fixes a regression introduced by the last hunk of
> 5ea5254aa0ad269cfbd2875c973ef25ab5b5e9db

Looking through my backlog, I noticed that the patch went also to
stable@xxxxxxxxxx and is now in various trees already.
So please forward this revert also to stable@xxxxxxx

Olaf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/