Re: [PATCH] fix sparse happy borkage when including gfp.h
From: Dave Hansen
Date: Fri Apr 15 2011 - 11:21:22 EST
On Fri, 2011-04-15 at 14:33 +0900, KOSAKI Motohiro wrote:
> > On Fri, 2011-04-15 at 12:14 +0900, KOSAKI Motohiro wrote:
> > > > #ifdef CONFIG_DEBUG_VM
> > > > - BUG_ON((GFP_ZONE_BAD >> bit) & 1);
> > > > + BUG_ON((GFP_ZONE_BAD >> bit) & 1);
> > > > #endif
> > > > - }
> > > > return z;
> > >
> > > Why don't you use VM_BUG_ON?
> > I was just trying to make a minimal patch that did a single thing.
> > Feel free to submit another one that does that. I'm sure there are a
> > couple more places that could use similar love.
> I posted another approach patches a second ago. Could you please see it?
Those both look sane to me. Those weren't biting me in particular, and
they don't fix the issue I was seeing. But, they do seem necessary to
reduce some of the noise.
CC'ing the sparse mailing list. We're seeing a couple of cases where
some gcc-isms are either stopping sparse from finding real bugs:
or creating a lot of noise on some builds:
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/