Re: [PATCH] xen block backend driver.

[Christoph Hellwig]

> +#define WRITE_BARRIER	(REQ_WRITE | REQ_FLUSH | REQ_FUA)

Any in case you want to keep usingthis POS out of tree you really need
to fix this.  REQ_FLUSH | REQ_FUA is not equivalent to the old barrier
semantics that the Xen disk protocol exported to the guest.  You need
to drain the whole queue of outstanding I/Os as some old guest (at least
those using reiserfs, e.g. old SLES) rely on it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/