[PATCH] kbuild: fix W=1 with gcc 4.1.2 / 4.3.2

From: Sam Ravnborg
Date: Thu Apr 21 2011 - 17:27:24 EST


Building a kernel using W=1 with gcc 4.3.2 failed like this:

cc1: error: unrecognized command line option "-Wpacked-bitfield-compat"

Eric Dumazet <eric.dumazet@xxxxxxxxx> reported
that gcc 4.1.2 failed like this:

cc1: error: unrecognized command line option "-Wpacked-bitfield-compat"

Make these options dependent on the compiler.

Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
Cc: Dave Jones <davej@xxxxxxxxxx>
Cc: Eric Dumazet <eric.dumazet@xxxxxxxxx>
---

I considered wrapping all warnings in $(call cc-option, ...)
but I think we have the relevant warning options nailed now.

Sam

scripts/Makefile.build | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index d5f925a..f43aef7 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -64,7 +64,7 @@ KBUILD_EXTRA_WARNINGS += -Wcast-qual
KBUILD_EXTRA_WARNINGS += -Wcast-align
KBUILD_EXTRA_WARNINGS += -Wconversion
KBUILD_EXTRA_WARNINGS += -Wdisabled-optimization
-KBUILD_EXTRA_WARNINGS += -Wlogical-op
+KBUILD_EXTRA_WARNINGS += $(call cc-option, -Wlogical-op)
KBUILD_EXTRA_WARNINGS += -Wmissing-declarations
KBUILD_EXTRA_WARNINGS += -Wmissing-format-attribute
KBUILD_EXTRA_WARNINGS += $(call cc-option, -Wmissing-include-dirs,)
@@ -73,7 +73,7 @@ KBUILD_EXTRA_WARNINGS += -Wnested-externs
KBUILD_EXTRA_WARNINGS += -Wold-style-definition
KBUILD_EXTRA_WARNINGS += $(call cc-option, -Woverlength-strings,)
KBUILD_EXTRA_WARNINGS += -Wpacked
-KBUILD_EXTRA_WARNINGS += -Wpacked-bitfield-compat
+KBUILD_EXTRA_WARNINGS += $(call cc-option, -Wpacked-bitfield-compat)
KBUILD_EXTRA_WARNINGS += -Wpadded
KBUILD_EXTRA_WARNINGS += -Wpointer-arith
KBUILD_EXTRA_WARNINGS += -Wredundant-decls
--
1.6.0.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/