RE: [PATCH 2/2] misc: add real functionopen/read/write/ioctl/close for moxa_serial_io driver

[Joe Perches]

On Mon, 2011-04-25 at 10:35 +0800, Jimmy Chen (éæé) wrote:
> Add real function and GPL license.
> Signed-off-by: Jimmy Chen <jimmy.chen@xxxxxxxx>

A few things.

o Your patches are reversed.
o Please run your patches through checkpatch.
o I think it better to avoid duplicating all of the GPL
  and just reference it as you have via MODULE_LICENSE.
o You could probably use MODULE_LICENSE("GPL V2")
  if you want to limit it to V2 only.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/