RE: [PATCH 2/2] misc: add real function open/read/write/ioctl/close for moxa_serial_io driver

[Jimmy Chen (???)]

Greg,
	I'm not sure what you mean "Can't you do all of this from userspace without any kernel changes needed?". Is there anyway to trigger the I/O control from userspace without driver? V2100 boards connect I/O to uart chip, tuning the I/O will switch the uart chip into different mode. "moxa_serial_io" is not a serial driver; the uart itself is droved by another serial driver such as mxser.c or 8250 driver.

-----Original Message-----
From: Greg KH [mailto:gregkh@xxxxxxx] 
Sent: Monday, April 25, 2011 11:02 AM
To: Jimmy Chen (???); linux-kernel@xxxxxxxxxxxxxxx
Cc: Joe Perches
Subject: Re: [PATCH 2/2] misc: add real function open/read/write/ioctl/close for moxa_serial_io driver

On Sun, Apr 24, 2011 at 07:47:23PM -0700, Joe Perches wrote:
> On Mon, 2011-04-25 at 10:35 +0800, Jimmy Chen (???) wrote:
> > Add real function and GPL license.
> > Signed-off-by: Jimmy Chen <jimmy.chen@xxxxxxxx>
> 
> A few things.
> 
> o Your patches are reversed.
> o Please run your patches through checkpatch.
> o I think it better to avoid duplicating all of the GPL
>   and just reference it as you have via MODULE_LICENSE.
> o You could probably use MODULE_LICENSE("GPL V2")
>   if you want to limit it to V2 only.

And finally, why does this need to be a kernel driver at all?  Can't you
do all of this from userspace without any kernel changes needed?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/