Re: [PATCH] Staging: xgifb: Fixed style issues.

[Joe Perches]

On Tue, 2011-04-26 at 12:12 +0800, Kenji Toyama wrote:
> Now there's only 10 errors and 1 warning given by checkpatch.pl, and
> these are related initialization of statics. The only warning left can
> be safely ignored I believe.
[]
>  static DEFINE_PCI_DEVICE_TABLE(xgifb_pci_table) = {
> -	{ PCI_VENDOR_ID_XG, PCI_DEVICE_ID_XG_20, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
> -	{ PCI_VENDOR_ID_XG, PCI_DEVICE_ID_XG_27, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1},
> -	{ PCI_VENDOR_ID_XG, PCI_DEVICE_ID_XG_40, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 2},
> -	{ PCI_VENDOR_ID_XG, PCI_DEVICE_ID_XG_42, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 3},
> -	{ 0 }
> +	{PCI_VENDOR_ID_XG, PCI_DEVICE_ID_XG_20, PCI_ANY_ID, PCI_ANY_ID,
> +	 0, 0, 0},
> +	{PCI_VENDOR_ID_XG, PCI_DEVICE_ID_XG_27, PCI_ANY_ID, PCI_ANY_ID,
> +	 0, 0, 1},
> +	{PCI_VENDOR_ID_XG, PCI_DEVICE_ID_XG_40, PCI_ANY_ID, PCI_ANY_ID,
> +	 0, 0, 2},
> +	{PCI_VENDOR_ID_XG, PCI_DEVICE_ID_XG_42, PCI_ANY_ID, PCI_ANY_ID,
> +	 0, 0, 3},
> +	{0}

Not an improvement.
You might use PCI_VDEVICE.
>  #define MODE_INDEX_NONE           0  /* TW: index for mode=none */
> -	{"none",         0xFF, 0x0000, 0x0000,    0,    0,  0, 0,   0,  0, MD_XGI300|MD_XGI315},  /* TW: for mode "none" */
[]
> +	{"none",         0xFF, 0x0000, 0x0000,    0,    0,  0, 0,   0,  0,
> +	 MD_XGI300|MD_XGI315},  /* TW: for mode "none" */

Again, not an improvement.
Not everything needs to be 80 columns.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/