Re: [PATCH 029/173] pata_mpc52xx: inherit from ata_bmdma_port_ops

[Sergei Shtylyov]

Hello.

On 26-04-2011 0:03, Willy Tarreau wrote:

> 2.6.27.59-stable review patch.  If anyone has any objections, please let us know.

   DMA support was added to this driver only in 2.6.29, hence this patch is 
not needed in 2.6.27.y...

> ------------------

> From: Tejun Heo<tj@xxxxxxxxxx>

> commit 77c5fd19075d299fe820bb59bb21b0b113676e20 upstream.

> pata_mpc52xx supports BMDMA but inherits ata_sff_port_ops which
> triggers BUG_ON() when a DMA command is issued.  Fix it.

> Signed-off-by: Tejun Heo<tj@xxxxxxxxxx>
> Reported-by: Roman Fietze<roman.fietze@xxxxxxxxxxxxx>
> Cc: Sergei Shtylyov<sshtylyov@xxxxxxxxxx>
> Signed-off-by: Jeff Garzik<jgarzik@xxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman<gregkh@xxxxxxx>

> ---
>   drivers/ata/pata_mpc52xx.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> --- a/drivers/ata/pata_mpc52xx.c
> +++ b/drivers/ata/pata_mpc52xx.c
> @@ -610,7 +610,7 @@ static struct scsi_host_template mpc52xx
>   };
>
>   static struct ata_port_operations mpc52xx_ata_port_ops = {
> -	.inherits		=&ata_sff_port_ops,
> +	.inherits		=&ata_bmdma_port_ops,
>   	.sff_dev_select		= mpc52xx_ata_dev_select,
>   	.set_piomode		= mpc52xx_ata_set_piomode,
>   	.set_dmamode		= mpc52xx_ata_set_dmamode,

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/