Re: [PATCH] usbvision: remove (broken) image format conversion

From: Hans de Goede
Date: Tue Apr 26 2011 - 07:11:11 EST


Hi,

On 04/26/2011 08:32 AM, Hans Verkuil wrote:
On Monday, April 25, 2011 23:23:17 Ondrej Zary wrote:
The YVU420 and YUV422P formats are broken and cause kernel panic on use.
(YVU420 does not work and sometimes causes "unable to handle paging request"
panic, YUV422P always causes "NULL pointer dereference").

As V4L2 spec says that drivers shouldn't do any in-kernel image format
conversion, remove it completely (except YUYV).

What really should happen is that the conversion is moved to libv4lconvert.
I've never had the time to tackle that, but it would improve this driver a
lot.

Would you perhaps be interested in doing that work?


Seconded! I would be more then happy to help with the libv4l part (in the form
of review + merging + advice).

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/