Re: [PATCH 2/2] watchdog: add real function on MOXA V2100 watchdogdriver

[Wim Van Sebroeck]

Hi Jimmy,

> From: Jimmy Chen <jimmy.chen@xxxxxxxx>
> 
> Add real function for watchdog driver
> 
> Signed-off-by: Jimmy Chen <jimmy.chen@xxxxxxxx>

My first remarks:
* This driver doesn't use /dev/watchdog.
* It doesn't follow the IOCTL API for watchdog devices
* It uses .ioctl and not an .unlocked_ioctl

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/