Re: [PATCH 20/25] Staging: hv: Use the probe function in structhv_driver

[Christoph Hellwig]

> @@ -882,7 +882,7 @@ static int blkvsc_drv_init(void)
>  
>  	drv->driver.name = storvsc_drv_obj->base.name;
>  
> -	drv->driver.probe = blkvsc_probe;
> +	drv->probe = blkvsc_probe;
>  	drv->driver.remove = blkvsc_remove;
>  	drv->driver.shutdown = blkvsc_shutdown;

Not new in this patch, but you should really declare the driver as a
static object and initialize it at compile time, similar to how it's 
done for PCI and countless other busses, e.g.

struct hv_driver blkvsc_driver {
	.name		= "blkvsc",
	.probe		= blkvsc_probe,
	.remove		= blkvsc_remove,
	.shutdown	= blkvsc_shutdown,
};

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/