Re: [PATCH] linux/string.h: Introduce streq macro.

[Thiago Farina]

+Copying Andrew and Joe.

On Tue, Apr 26, 2011 at 4:45 PM, Thiago Farina <tfransosi@xxxxxxxxx> wrote:
> This macro is arguably more readable than its variants:
> - !strcmp(a, b)
> - strcmp(a, b) == 0
>
> Signed-off-by: Thiago Farina <tfransosi@xxxxxxxxx>
> ---
> ÂChanges from v1 (Steven and Alexey review):
> Â- Convert from macro to static inline.
> Â- Remove the example.
> Â- Add the suggested comment by Steven.
>
> Âinclude/linux/string.h | Â 15 +++++++++++++++
> Â1 files changed, 15 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/string.h b/include/linux/string.h
> index a716ee2..d859bb2 100644
> --- a/include/linux/string.h
> +++ b/include/linux/string.h
> @@ -134,6 +134,21 @@ extern ssize_t memory_read_from_buffer(void *to, size_t count, loff_t *ppos,
> Â Â Â Â Â Â Â Â Â Â Â Âconst void *from, size_t available);
>
> Â/**
> + * streq - Are two strings equal?
> + * @a: first string
> + * @b: second string
> + *
> + * Use: streq(a, b)
> + * Instead of: strcmp(a, b) == 0 or !strcmp(a, b)
> + *
> + * This makes the code more readable and less error prone.
> + */
> +static inline int streq(const char *a, const char *b)
> +{
> + Â Â Â return strcmp(a, b) == 0;
> +}
> +
> +/**
> Â* strstarts - does @str start with @prefix?
> Â* @str: string to examine
> Â* @prefix: prefix to look for.
> --
> 1.7.5.rc2.5.g60e19
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/