Re: [PATCH 3/4] Documentation/00-INDEX.sh: add script to helpkeeping the index up-to-date

[Randy Dunlap]

On Sun, 24 Apr 2011 11:58:11 -0700 Randy Dunlap wrote:

> On Sat, 23 Apr 2011 23:05:37 +0200 Cyril Brulebois wrote:
> 
> > Randy Dunlap <rdunlap@xxxxxxxxxxxx> (23/04/2011):
> > > The "undocumented" list looks correct (well, it could omit .orig
> > > files), but the "Documented but missing" list contains words, e.g.:
> > > [â]
> > 
> > One coffee laterâ Looks like your grep is behaving as if "grep -F" was
> > passed; that might be better with an explicit "grep -G" (which is the
> > default), see patch below?
> 
> Sorry, this patch didn't help (did not change the output).
> 
> > diff --git a/Documentation/00-INDEX.sh b/Documentation/00-INDEX.sh
> > index 31d92d2..f22c260 100755
> > --- a/Documentation/00-INDEX.sh
> > +++ b/Documentation/00-INDEX.sh
> > @@ -4,7 +4,7 @@
> >  # Try and keep the 00-INDEX file up-to-date.
> >  
> >  # List all entries below the 00-INDEX entry:
> > -documented=$(sed '1,/^00-INDEX$/d' 00-INDEX|grep -v '^\s'|sed 's,/$,,')
> > +documented=$(sed '1,/^00-INDEX$/d' 00-INDEX|grep -G -v '^\s'|sed 's,/$,,')
> >  
> >  # List all files/directories except 00-INDEX* and Makefile:
> >  present=$(ls -1|grep -v '^00-INDEX'|grep -v '^Makefile$')
> > 
> > 
> > Maybe some grep alias in your environment? I couldn't reproduce the
> > behaviour you mentioned even using (unpack+PATH+LD_LIBRARY_PATH)
> > pcre-7.8-2.fc11.ppc.rpm and sed-4.2.1-1.fc11.ppc.rpm, until I tried
> > various options like passing -F to grep.
> 
> I couldn't find any grep alias, but I changed "grep" in 00-INDEX.sh to "/bin/grep"
> anyway, and still got the same results.

ad I don't see any environment variables that would affect grep either.

Anyway, using this line instead of any one of the lines above works for me:

documented=$(sed '1,/^00-INDEX$/d' 00-INDEX|grep -G -v ^[[:space:]]|sed 's:/$::')

i.e., use ^[[:space:]] instead of the (original) '^\s'.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/