Re: [PATCH V3] tty/serial: add support for Xilinx PS UART

[Alan Cox]

> I thought I was improving but now as I look at it further, that seems like it 
> was better and I should have stuck to that method.
> 
> Thoughts?

Go for nearest is the right behaviour. The whole tty layer works on that
basis as do soem other things. It means you don't have to have a set of
calls to do things like "enumerate valid data rates" instead you ask and
compare.

> > > +	uart_update_timeout(port, termios->c_cflag, baud);
> > 
> > [which would also fix this timeout!]
> 
> Maybe you were meaning that if the baud rate was not really set because of the
> error this timeout would be wrong also, and if so that makes sense.

Correct

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/